New @turnkey/iframe-stamper package and email recovery example
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
andrewkmin
reviewed
Oct 13, 2023
| /** | ||
| * Inserts the iframe on the page and returns a promise resolving to the iframe's public key | ||
| */ | ||
| async init(): Promise<string> { |
packages/iframe-stamper/src/index.ts
Outdated
| // Instead of erroring out we simply return. Not our event! | ||
| return; | ||
| } | ||
| if (event.data && event.data["type"] == "BUNDLE_INJECTED") { |
There was a problem hiding this comment.
tiny nit - same optional chaining pattern here (don't feel strongly).
could be useful to throw some of these types into consts in a single place
r-n-o
force-pushed
the
rno/iframe-stamper
branch
from
c0f7f9c to
16a167e
Compare
emostov
reviewed
Oct 16, 2023
emostov
reviewed
Oct 16, 2023
emostov
reviewed
Oct 16, 2023
emostov
reviewed
Oct 16, 2023
emostov
reviewed
Oct 16, 2023
emostov
reviewed
Oct 16, 2023
emostov
reviewed
Oct 16, 2023
emostov
reviewed
Oct 16, 2023
emostov
reviewed
Oct 16, 2023
emostov
reviewed
Oct 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR adds a new package:
@turnkey/iframe-stamper. This is an abstraction to work with iframes as signers (aka stampers).Right now I envision
@turnkey/iframe-stamperto be used mostly via our upcoming email recovery flow, but I can see this "iframe as stampers" idea being useful for other flows in the future: iframes and localStorage could be used to hold standard API keys rather than recovery credentials.The new example covers the recovery flow.
How I Tested These Changes
recovery-first-cut.mov
Local testing for now. There's still a bunch of work that needs to be done to complete the example, but having this PR out in the open will be useful to get feedback!